[PHB24] Fixes from Testing#4
Merged
FreshRoyal merged 7 commits intoFreshRoyal:phb24-misc-fixesfrom Mar 16, 2026
Merged
Conversation
NickVendel
commented
Mar 15, 2026
NickVendel
commented
- misc. changes (more in individual commits)
• moved elements from Internal source/file to ALE, in order for them to still appear under Additional Proficiency category of equipment. • removed requirements from Boon's ASI elements. • fixed incorred Proficiency in the Guide Background • fixed many instances of incorrect description formatting. • blocked multiclass version of the Fighter from gaining Class's Skill Proficiencies. • removed unnecessary parentheses from requirements of Cunning Strike selects. • changed Boon and non-Origin Feat requirements to character level instead of Class level, allowing for mutliclass characters to pick up them once character reaches relevant level. • added missing stats to Irresistible Offense sub-elements. • fixed copy-paste typo in Observant Feat. • added a note to the PHB24 source, that recognizes it as a `D&D 5.5e` source. • fixed wrong Proficiency grant in the PHB Rogue class. • Draconic language and new Polearm proficiency is placed back under PHB source, to hide it when the source is disabled in favor of PHB24 version of relevant elements.
• blocked ability for Warlock to take mutliple versions of the same Eldritch Invocation • blocked ability for Sorcerer to take multiple versions of the same Metamagic • also some minor fixes, including: removal of appends in the Eldritch Invocation file, moving those relevant selects to the Class instead; changed formatting to PHB's Eldritch Invocations file; removed pointless Feature Replacement Grants from Metamagic options.
• added Optional Background Feature to PHB24 source, which allows to take Origin Feat by Backgrounds pre-PHB24 Backgrounds as suggested by PHB24 rules. • changed supports for PHB24 Battle Master's Maneuvers to avoid duplicates and any potential mechanical issues in the future. • added references to all of the PHB24 Backgrounds so that it's easier to choose Background based on a given Feat. • added proper prerequisites to PHB24 Druidic Warrior Feat. • added PHB24 Pacts to the requirements of pre-PHB24 invocations, so that you can still take previous versions of the Invocations even if you use new Pacts.
• also swapped `&&` to `,` in both Elf Races, not a breaking change. • there's a breaking change in both Bard's and Warlock's Mage of Strixhaven Subclasses, due to a fix to a copy-paste typo.
FreshRoyal
approved these changes
Mar 15, 2026
FreshRoyal
added a commit
that referenced
this pull request
Apr 5, 2026
* Fixed expertise IDs for Scholar feature * Pact of the Chain and Find Familiar fixes Added requirements to ensure no duplicate familiar selection from 2024 Pact of the Chain * Added familiar select to 2014 Find Familiar * Apply suggestions that GitHub disregarded * Fix Keen Senses selection * Added Blessed Warrior prerequisite text and changed 2014 Barbarian and 2024 Monk capstone ASIs * Forgot to fix language supports * 2024 Barbarian capstone changes and added Keen Senses description to Elf * Fixed Greatclub ID * Change Blessed Warrior prerequisite Co-authored-by: NickVendel <46818179+NickVendel@users.noreply.github.com> * Apply suggestions from code review Co-authored-by: NickVendel <46818179+NickVendel@users.noreply.github.com> * [PHB24] Fixes from Testing (#4) * Misc. Fixes • moved elements from Internal source/file to ALE, in order for them to still appear under Additional Proficiency category of equipment. • removed requirements from Boon's ASI elements. • fixed incorred Proficiency in the Guide Background • fixed many instances of incorrect description formatting. • blocked multiclass version of the Fighter from gaining Class's Skill Proficiencies. • removed unnecessary parentheses from requirements of Cunning Strike selects. • changed Boon and non-Origin Feat requirements to character level instead of Class level, allowing for mutliclass characters to pick up them once character reaches relevant level. • added missing stats to Irresistible Offense sub-elements. • fixed copy-paste typo in Observant Feat. • added a note to the PHB24 source, that recognizes it as a `D&D 5.5e` source. • fixed wrong Proficiency grant in the PHB Rogue class. • Draconic language and new Polearm proficiency is placed back under PHB source, to hide it when the source is disabled in favor of PHB24 version of relevant elements. * Blocked duplicates • blocked ability for Warlock to take mutliple versions of the same Eldritch Invocation • blocked ability for Sorcerer to take multiple versions of the same Metamagic • also some minor fixes, including: removal of appends in the Eldritch Invocation file, moving those relevant selects to the Class instead; changed formatting to PHB's Eldritch Invocations file; removed pointless Feature Replacement Grants from Metamagic options. * More Fixes and Compatibility Changes • added Optional Background Feature to PHB24 source, which allows to take Origin Feat by Backgrounds pre-PHB24 Backgrounds as suggested by PHB24 rules. • changed supports for PHB24 Battle Master's Maneuvers to avoid duplicates and any potential mechanical issues in the future. • added references to all of the PHB24 Backgrounds so that it's easier to choose Background based on a given Feat. • added proper prerequisites to PHB24 Druidic Warrior Feat. • added PHB24 Pacts to the requirements of pre-PHB24 invocations, so that you can still take previous versions of the Invocations even if you use new Pacts. * correcting sources * Compatibility Fixes for Subclasses • also swapped `&&` to `,` in both Elf Races, not a breaking change. • there's a breaking change in both Bard's and Warlock's Mage of Strixhaven Subclasses, due to a fix to a copy-paste typo. * fix copy-paste error * Updated versions Co-authored-by: NickVendel <46818179+NickVendel@users.noreply.github.com> * Replaced "grant name=" with "grant id=" * Apply suggestions from code review Co-authored-by: Tel0k <94142741+Tel0k@users.noreply.github.com> Co-authored-by: NickVendel <46818179+NickVendel@users.noreply.github.com> Co-authored-by: tregolani <64651202+tregolani@users.noreply.github.com> * Ability Score Maximum Fixes (#5) * Misc. Fixes • moved elements from Internal source/file to ALE, in order for them to still appear under Additional Proficiency category of equipment. • removed requirements from Boon's ASI elements. • fixed incorred Proficiency in the Guide Background • fixed many instances of incorrect description formatting. • blocked multiclass version of the Fighter from gaining Class's Skill Proficiencies. • removed unnecessary parentheses from requirements of Cunning Strike selects. • changed Boon and non-Origin Feat requirements to character level instead of Class level, allowing for mutliclass characters to pick up them once character reaches relevant level. • added missing stats to Irresistible Offense sub-elements. • fixed copy-paste typo in Observant Feat. • added a note to the PHB24 source, that recognizes it as a `D&D 5.5e` source. • fixed wrong Proficiency grant in the PHB Rogue class. • Draconic language and new Polearm proficiency is placed back under PHB source, to hide it when the source is disabled in favor of PHB24 version of relevant elements. * Blocked duplicates • blocked ability for Warlock to take mutliple versions of the same Eldritch Invocation • blocked ability for Sorcerer to take multiple versions of the same Metamagic • also some minor fixes, including: removal of appends in the Eldritch Invocation file, moving those relevant selects to the Class instead; changed formatting to PHB's Eldritch Invocations file; removed pointless Feature Replacement Grants from Metamagic options. * More Fixes and Compatibility Changes • added Optional Background Feature to PHB24 source, which allows to take Origin Feat by Backgrounds pre-PHB24 Backgrounds as suggested by PHB24 rules. • changed supports for PHB24 Battle Master's Maneuvers to avoid duplicates and any potential mechanical issues in the future. • added references to all of the PHB24 Backgrounds so that it's easier to choose Background based on a given Feat. • added proper prerequisites to PHB24 Druidic Warrior Feat. • added PHB24 Pacts to the requirements of pre-PHB24 invocations, so that you can still take previous versions of the Invocations even if you use new Pacts. * correcting sources * Compatibility Fixes for Subclasses • also swapped `&&` to `,` in both Elf Races, not a breaking change. • there's a breaking change in both Bard's and Warlock's Mage of Strixhaven Subclasses, due to a fix to a copy-paste typo. * fix copy-paste error * Fixes for Ability Score Maximum rules Change to make sure Ability Score Maximum setting works as intended while still blocking stacking for most elements that increase ability score's maximum. --------- Co-authored-by: NickVendel <46818179+NickVendel@users.noreply.github.com> Co-authored-by: Tel0k <94142741+Tel0k@users.noreply.github.com> Co-authored-by: tregolani <64651202+tregolani@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.